Skip to content

revert logic from event conversations PRs #5003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented May 27, 2025

.. while making sure logic from near/far future events remains and archived conversation handling is fixed (must not show up in main conversations list).

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

.. while making sure logic from near/far future events remains and archived conversation handling is fixed (must not show up in main conversations list).

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi self-assigned this May 27, 2025
@mahibi mahibi added the 3. to review Waiting for reviews label May 27, 2025
@mahibi mahibi changed the title change some logic from event conversations PRs revert logic from event conversations PRs May 27, 2025
@mahibi
Copy link
Collaborator Author

mahibi commented May 27, 2025

@sowjanyakch please check if i oversaw something that was solved with your PRs but not with this one

Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9999
Errors1010

SpotBugs

CategoryBaseNew
Bad practice66
Correctness22216
Dodgy code7167
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310100

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5003-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

@sowjanyakch sowjanyakch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event conversations that take place after 16 hours are excluded from filter. If you create an event conversation that occurs after 16 hours, post a message, and mark it as unread, it won’t show up under the “Unread” filter. This is the same case for unread mentions and archived filters.

@mahibi
Copy link
Collaborator Author

mahibi commented May 30, 2025

will take a closer later.
So not merging for v21.1

@mahibi mahibi marked this pull request as draft May 30, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants