Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Copy Message Link to context menu actions #1845

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Oct 21, 2024

@SystemKeeper
Copy link
Collaborator

SystemKeeper commented Oct 21, 2024

Cool stuff 👍

Regarding https://github.com/nextcloud/talk-ios/actions/runs/11442426101/job/31832743043?pr=1845, you need to run generate-localizable-strings-file.sh to update the localizable files if you change any translations :)

- Added Copy Message Link to context menu actions
- uses LinkUrl and updated localizable file
- refactor to avoid force unwrapping

Signed-off-by: rapterjet2004 <[email protected]>
@rapterjet2004 rapterjet2004 force-pushed the issue-1816-copy-message-link branch from 8e2f61e to efe2a8c Compare October 25, 2024 13:44
Copy link
Collaborator

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks a lot :)

Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR @rapterjet2004 :) Nice work!

@Ivansss Ivansss enabled auto-merge October 25, 2024 16:18
@Ivansss Ivansss merged commit 4bba72b into master Oct 25, 2024
11 checks passed
@Ivansss Ivansss deleted the issue-1816-copy-message-link branch October 25, 2024 17:29
@Ivansss
Copy link
Member

Ivansss commented Oct 30, 2024

/backport to stable20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy link to message
3 participants