Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add allowed_view_extensions config node #6564

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Koc
Copy link

@Koc Koc commented Oct 26, 2024

📝 Summary

It isn't possible to view md files if they were shared without allow downloading. Related to nextcloud/server#48903

🔍 Repoducer

Share file without download possibility

image

Try to view file as share recipient

image

To fix that we can introduce a new allowed_view_extensions config node.

  'allowed_view_extensions' => [
    'md',
    // ...
  ]

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@Koc Koc requested review from juliusknorr and max-nextcloud and removed request for mejo- and max-nextcloud October 26, 2024 14:08
@Koc Koc force-pushed the feature/add-allowed-view-extensions-config branch from ba678d2 to bf2f624 Compare October 26, 2024 14:09
@Koc Koc requested a review from mejo- October 26, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant