[nextest-runner] add a way to pass extra args at runtime #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1968 +/- ##
==========================================
+ Coverage 80.37% 80.39% +0.01%
==========================================
Files 92 93 +1
Lines 22673 22701 +28
==========================================
+ Hits 18223 18250 +27
- Misses 4450 4451 +1 ☔ View full report in Codecov by Sentry. |
Add a way to do this: ```toml [[profile.default.overrides]] filter = ... phase.run.extra-args = ``` See #1959 for why this is required. This is an advanced option that should be used with care, but it's worth implementing. The `phase.run` is because (a) we may want `phase.list` in the future as well, and (b) in the future, we'll want to support setting the environment here as well.
sunshowers
force-pushed
the
extra-args
branch
from
bf1a9d3 to
547b2e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to do this:
See #1959 for why this is required. This is an advanced option that should be used with care, but it's worth implementing.
The
phase.runis because (a) we may wantphase.listin the future as well, and (b) in the future, we'll want to support setting the environment here as well.