Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove raw #s that are unnecessary #1976

Conversation

hamirmahal
Copy link
Contributor

Closes #1975

Copy link
Contributor Author

@hamirmahal hamirmahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't result in any user-facing changes.

The goal here is to improve code readability and developer productivity.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.62%. Comparing base (4e6c61c) to head (d4c6f9f).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
- Coverage   80.62%   80.62%   -0.01%     
==========================================
  Files          95       95              
  Lines       23071    23071              
==========================================
- Hits        18601    18600       -1     
- Misses       4470     4471       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamirmahal hamirmahal force-pushed the refactor/remove-raw-hashes-that-are-unnecessary branch from 149016f to d4c6f9f Compare December 13, 2024 20:31
@sunshowers
Copy link
Member

These look reasonable, thank you.

@sunshowers sunshowers merged commit bd006da into nextest-rs:main Dec 14, 2024
17 of 18 checks passed
@hamirmahal hamirmahal deleted the refactor/remove-raw-hashes-that-are-unnecessary branch December 14, 2024 01:19
@hamirmahal
Copy link
Contributor Author

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary #s in nextest-runner/src/ and integration-tests/tests/integration/main.rs
2 participants