cancellation-related cleanup #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've changed things such that the executor always checks in with the dispatcher before starting a unit. This makes the bool unnecessary. The cancel receiver is currently necessary for the handle_delay_between_attempts step, which should cancel the run no matter what. We'll remove this shortly by moving this functionality into req_rx.
This functionality is now provided by the dispatcher via the request channel.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
- Coverage 80.61% 80.59% -0.03%
==========================================
Files 95 95
Lines 23094 23062 -32
==========================================
- Hits 18617 18586 -31
+ Misses 4477 4476 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request channel with the dispatcher provides a principled way to do cancellation-related cleanup.