wave conda: always installing procps in containers #3615
Conversation
Signed-off-by: Marco De La Pierre <[email protected]>
|
Would close nextflow-io/nf-wave#6 |
|
@pditommaso the test fail is a rate limit being hit. |
|
It would be better to rely on the Conda recipe to install this to avoid depending on distro specific command |
|
Do you know whether Or otherwise would you share privately the |
|
Ok, just did some checks on base images for ubuntu, debian, opensuse, alpine, amazonlinux. |
…rocps Signed-off-by: Marco De La Pierre <[email protected]>
|
Done, please have a look when you get the chance. |
Signed-off-by: Marco De La Pierre <[email protected]>
| @@ -397,6 +397,7 @@ class WaveClient { | |||
| FROM ${config.condaOpts().mambaImage} | |||
| COPY --chown=\$MAMBA_USER:\$MAMBA_USER conda.yml /tmp/conda.yml | |||
| RUN micromamba install -y -n base -f /tmp/conda.yml && \\ | |||
| micromamba install -y -n base conda-forge::procps-ng && \\ | |||
There was a problem hiding this comment.
I was thinking that instead of automagically adding dependencies in the container build it could be added an option to provide one or packages that should be a added in the resulting container e.g.
wave.conda.basePackages = 'conda-forge::procps-ng'
or
wave.conda.addPackages = 'conda-forge::procps-ng'
WDT?
There was a problem hiding this comment.
I like wave.conda.basePackages, I think it conveys the message.
Will implement as soon as I am finished with this week's duties.
|
Ok, I went ahead with this. Have a look at 7e82781. Thanks Marco! |
|
cool! |
Signed-off-by: Marco De La Pierre [email protected]