Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement some changes that were dropped when #5042 was merged #5063

Closed

Conversation

adamrtalbot
Copy link
Collaborator

@adamrtalbot adamrtalbot commented Jun 13, 2024

Some changes were dropped when @swampie's PR was merged. This PR re-adds them from scratch, will try and trim it down so we retain the relevant lines.

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 2e03135
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/666b1eb1e1e1150008974ce2

@adamrtalbot adamrtalbot changed the title Re-implement some changes that were dropped when https://github.com/nextflow-io/nextflow/pull/5042 was merged Re-implement some changes that were dropped when #5042 was merged Jun 13, 2024
@pditommaso
Copy link
Member

Can be added an integration tests here

NXF_CLOUDCACHE_PATH=az://my-data/cache \
$NXF_CMD -C ./azure.config \
run nextflow-io/rnaseq-nf \
-with-report \
-with-trace $OPTS \
-plugins nf-cloudcache \
-resume
[[ `grep -c 'Using Nextflow cache factory: nextflow.cache.CloudCacheFactory' .nextflow.log` == 1 ]] || false
[[ `grep -c 'Cached process > ' .nextflow.log` == 4 ]] || false

@adamrtalbot
Copy link
Collaborator Author

Can be added an integration tests here

NXF_CLOUDCACHE_PATH=az://my-data/cache \
$NXF_CMD -C ./azure.config \
run nextflow-io/rnaseq-nf \
-with-report \
-with-trace $OPTS \
-plugins nf-cloudcache \
-resume
[[ `grep -c 'Using Nextflow cache factory: nextflow.cache.CloudCacheFactory' .nextflow.log` == 1 ]] || false
[[ `grep -c 'Cached process > ' .nextflow.log` == 4 ]] || false

I think you have to run on a machine with a Managed Identity, which basically means on an Azure VM. I can expand some integration tests there though.

@pditommaso
Copy link
Member

Merge manually 306814e

@pditommaso pditommaso closed this Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants