Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs with v2 config parser #5854

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bugs with v2 config parser #5854

wants to merge 1 commit into from

Conversation

bentsherman
Copy link
Member

@bentsherman bentsherman commented Mar 4, 2025

This PR fixes a few issues I encountered while testing the v2 config parser against some nf-core configs

  • make sure config file passes its params to included configs
  • make sure profiles are evaluated only if they were enabled, to prevent unnecessary config inclusions (for example)
  • factor out DSLs for plugins, process, and profiles block to make the code easier to read

This PR should ideally be merged before the next edge release, so that the v2 config parser is usable by nf-core

Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 88aa31f
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/67c7875390c62100087b57d1
😎 Deploy Preview https://deploy-preview-5854--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant