Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate NomadSecrets store to resolve Nextflow config-secrets #76

Closed
abhi18av opened this issue Jul 29, 2024 · 4 comments Β· Fixed by #81
Closed

Accommodate NomadSecrets store to resolve Nextflow config-secrets #76

abhi18av opened this issue Jul 29, 2024 · 4 comments Β· Fixed by #81

Comments

@abhi18av
Copy link
Member

abhi18av commented Jul 29, 2024

Actually, I must add a clarification here since as of now we have two functional scenarios

Setup LocalStore NomadStore
Config vars βœ… πŸ”΄
Job vars βœ… βœ…
sun-nomadlab βœ… βœ…

βœ… Scenario-1

Config vars => LocalSecret store

Job vars => LocalSecret store

βœ… Scenario-2

Config vars => LocalSecret store

Job vars => NomadSecret store

πŸ”΄ Scenario-3

Config vars => NomadSecret store

Job vars => NomadSecret store

Conclusion

@jagedn , please correct me if I'm wrong - in scenario-3 we can't use the NomadSecret store for config vars due to the current design decisions on the Nextflow side, however we can support scenario-1 and scenario-2 just fine.

Originally posted by @abhi18av in #75 (comment)

@jagedn
Copy link
Collaborator

jagedn commented Aug 27, 2024

I think I founded an easy way to have also in config vars

obviously only case we'll not able to use secrets will be in the own plugin configuration, i.e.,

client {
        address = secrets.MY_HOST
    }

@abhi18av
Copy link
Member Author

Related #81 #79

@abhi18av abhi18av linked a pull request Aug 28, 2024 that will close this issue
@abhi18av
Copy link
Member Author

@jagedn , the #81 should address scenario-3 described here right? #76 (comment)

@jagedn
Copy link
Collaborator

jagedn commented Aug 28, 2024

@jagedn , the #81 should address scenario-3 described here right? #76 (comment)

yes, I think with this PR we cover all use cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants