improve secrets provider #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Aguilera <[email protected]>
abhi18av
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Hi @jaged 👋
This is looking good to merge, I have added some thoughts on the original discussion thread #79 (comment)
jagedn
commented
Aug 28, 2024
|
Mmm, sure @jagedn, cherry-picking the commit to another branch 👍 |
abhi18av
force-pushed
the
improve-secrets
branch
from
66dc755 to
0180d47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overwrite the
loadSecretscalled by the LocalSecretsProvider to load secrets stored in the nomad cluster so they can be used also in the configuration phasealso it contains a small refactor of the validation part