Add datacenters directive #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagedn
requested review from
matthdsm and
abhi18av
and removed request for
matthdsm
|
Thanks @jagedn , this is really looking good! I have marked this as draft PR to be able to test this one thoroughly, I think this refactor with custom directives really marks a new phase 🎉 |
|
version 0.0.3 is comming!!! |
closes #42 Signed-off-by: Jorge Aguilera <[email protected]>
closes #42 Signed-off-by: Jorge Aguilera <[email protected]>
|
fixed conflicts so this branch has also the multiple volumes features included |
|
@jagedn this GIF describes you! |
yes, when I'm sitting in the back seat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extend the allowed directives with custom nomad directives as
datacenterslittle refactor of the NomadService into some functions instead to have a mega-method