-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run validation pipelines in azure using github action #85
Conversation
Signed-off-by: Jorge Aguilera <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Jorge for taking this forward!
I have added my thoughts regarding the use of this bigger environment for us.
But we can implement the suggestion later sometime later, for now this makes for a good test already.
Happy to go with whatever you judge is best.
name: Build nf-nomad | ||
if: "!contains(github.event.head_commit.message, '[ci skip]')" | ||
runs-on: nfazure | ||
timeout-minutes: 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we'll need a longer timeout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope 10 mnts will be enough but it will depends how many pipelines we want to include in the test for example ... so we'll see
.github/workflows/nfazure.yml
Outdated
GRADLE_OPTS: '-Dorg.gradle.daemon=false' | ||
|
||
- name: Install | ||
run: ./gradlew clean unzipPlugin -x test -P version=$(git rev-parse --short "$GITHUB_SHA") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagedn , is the overall idea to build the plug-in and test with local asset?
Maybe we can use nfazure
for testing a proper release, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right now, with current PR, the idea is to run the GH action against some branch/commit but yes, can be a good idea to use nfazure
as version name. I will change it
Signed-off-by: Jorge Aguilera <[email protected]>
* run validation pipelines in azure using github action Signed-off-by: Jorge Aguilera <[email protected]>
the aim of this PR is to be able to run the build process using current commit as nf-nomad version and them run some pipelines all of them using a custom runner called
nfazure
by the moment is executed manually and once validated we can decide how/where to execute automatically