Commented 2 unnecessary indexes present in a few D_MC and D_MM tables. #4565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cturczynskyj
added
Internal-Issue-Created
|
I am not sure if I should merge it or not. |
|
@billmask Thank you for your Pull Request. We are interested in considering your contribution but before it can be included in an official branch or release, we need to receive a signed copy of our Contributor License Agreement. Please review the Source Code Contribution page for more details and then sign and return the agreement as instructed. |
|
@billmask - Take a look at the comment above from Jackie. We need the contributor's agreement signed this month for planning purposes for 4.3. Thanks in advance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in Issue 4551 there are indexes that uses the same first column or columns as the Primary Key indexes. This make them unnecessary. They only slow down DMLs and uses storage.
I commented, not deleted, them. But if you want I can delete. It is quite hard to test this, as nothing in application behavior will change.