-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #6276 fix #6296
base: development
Are you sure you want to change the base?
Issue #6276 fix #6296
Conversation
Linking to parent issue #6276 |
Created a PR to include a unit test. |
You only want the changes to If you don't actually care about keeping any of the other changes, do an interactive rebase with your
If you want to keep your changes to the .project and .gitignore files locally, again do this with your
The force push at the end of either method will automatically update this PR to remove the unwanted commits. |
As suggested by Tony, I used his rebase method to omit the unwanted changes from my previous commits. |
Seems you rebased off the wrong branch as it contains changes for a separate issue. |
Rebased and pushed again to remove unrelated changes. |
Nice. Could you also merge by PR listed above which includes a unit test? Once you merge it, it should show up here without any extra steps. |
@rogin - I merged your PR, but it looks like yours had some unrelated changes as well. |
@Shurazi starting with your bug branch checked out
The reason the original commits came back in the merge was because @rogin created his branch before you cleaned up your side. A rebase in @rogin's fork prior to merging would have cleaned that up. |
(cherry picked from commit 30d2760)
@Shurazi - Excellent work! I am very happy that you and tonygermano and rogin worked together to clean up the PR. Sometimes the cleaning is more work than the original code change! |
Preserve HTTP Parameter order by using a LinkedHashMap instead of HashMap in HttpUtil:getTableMap