-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port eval-region to squint #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good! Apart from the fact that Alt + Enter
in the squint demo also breaks the line. To avoid that I think you have to return true
from the key handler.
What do you mean with breaks the line? I'm not sure if I can see what you mean |
|
@zampino Should be fixed now. @mk @zampino Note that I added this to package.json:
so you can write This should actually also be done if you want to import the other extensions explicitly but we can address that in a later PR/version. My point is more about: is this style the way we want it. |
See https://snapshots.nextjournal.com/clojure-mode/build/9a448e92b43fc0f6b3e1724d8ac1b1d7ca1000b3/squint/dist/index.html for a demo.
@zampino Note that I also updated the keys in the HTML since they weren't accurate.