Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.13] nmc/2003-Main_Settings_Dialog #271

Closed
wants to merge 31 commits into from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot added the custom MagentaCLOUD customisation label Jul 12, 2024
@memurats memurats added approved build-ready Include into custom client build labels Jul 12, 2024
claucambra and others added 14 commits August 12, 2024 13:43
Signed-off-by: Lorenzo Tanganelli <[email protected]>
mgallien and others added 6 commits August 12, 2024 13:43
when receiving a shell integration socket command for ENCRYPT, a generic
interface and generic code paths was used

the assumption was that the listener socket would need (and remain)
valid while hanlding teh request

some code paths need to display error messages to the user via a
QMessageBox

the issue is that this will execute a Qt event loop that will handle the
socket disconnection while the socket variable from the caller seems it
will stay valid and alive

prevent that by not using a blocking method invocation such that life
time mishandling about the socket listener is not possible

Signed-off-by: Matthieu Gallien <[email protected]>
@memurats memurats removed build-ready Include into custom client build approved labels Aug 13, 2024
@memurats memurats closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
custom MagentaCLOUD customisation
Projects
None yet
5 participants