Adds Slack notifications about releases, upgrades to nextmv-py v0.11.1 #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-quintero
approved these changes
Sep 18, 2024
.nextmv/release/main.py
Outdated
| @@ -241,5 +251,21 @@ def bump_marketplace_version( | |||
| return f"v{major}.{minor}.{patch}" | |||
|
|
|||
|
|
|||
| def notify_slack(url: str, app: str, version: str, marketplace_version: str): | |||
There was a problem hiding this comment.
The return type hint should be None
| response = requests.post( | ||
| url, | ||
| json={ | ||
| "text": f"Release notification - community-apps/{app} {version} / marketplace {marketplace_version}", |
There was a problem hiding this comment.
I think we should either only notify for prod or log the environment that is being released in here.
There was a problem hiding this comment.
Yeah, totally. I somehow missed the distinction here. The parameter is optional, so, I will simply drop it in the workflow if not targeting prod.
There was a problem hiding this comment.
Thanks for noticing! 🤗
|
This will need a fix for |
merschformann
changed the title
merschformann
force-pushed
the
merschformann/add-slack-notifications
branch
from
5c0cec7 to
95f368a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Slack notifications for improving internal transparency about ongoing releases.
Changes
--slack-urlparameter to release workflow commandnotify_slackfunction to send release notifications to Slackrequests>=2.26.0inrequirements.txtfor HTTP requests to Slack Webhooksnextmv-py==v0.11.1