Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds tests and workflows #1

Merged
merged 8 commits into from
Feb 23, 2024
Merged

Adds tests and workflows #1

merged 8 commits into from
Feb 23, 2024

Conversation

merschformann
Copy link
Member

@merschformann merschformann commented Feb 22, 2024 •
edited
Loading

Description

Adds tests and workflows to the repo.

Changes

  • Add golden file tests
  • Add lint and test workflows

Resolves ENG-4638, ENG-4635

@merschformann merschformann marked this pull request as draft February 22, 2024 01:08
@linear Linear
Copy link

linear bot commented Feb 22, 2024

ENG-4638 Move `mip` golden file tests

ENG-4635 Add `mip` repository(ies) workflows

Add workflows for new mip repository (or repositories)

@merschformann merschformann marked this pull request as ready for review February 22, 2024 01:46
larsbeck
larsbeck approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@larsbeck larsbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only one remark: Do we want the tests to live under tests/docs? Or should it just be tests?

@larsbeck larsbeck merged commit def66f9 into develop Feb 23, 2024
4 checks passed
@larsbeck larsbeck deleted the merschformann/add-tests-and-workflows branch February 23, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsbeck larsbeck larsbeck approved these changes

@sebastian-quintero sebastian-quintero Awaiting requested review from sebastian-quintero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merschformann @larsbeck