Fix direct precedence constraint violation in model_constraint_direct…

…_precedences.go

model_constraint_direct_precedence_test.go

@@ -90,5 +90,4 @@ func TestDirectPrecedenceConstraint_EstimateIsViolated(t *testing.T) {
 	if planned {
 		t.Error("expected move to not be planned")
 	}
-
 }

model_constraint_direct_precedences.go

@@ -75,9 +75,13 @@ func (l *directPrecedencesConstraintImpl) EstimateIsViolated(
 	modelImpl := move.PlanStopsUnit().Solution().Model().(*modelImpl)
 	stopPositions := move.StopPositions()
 	for _, stopPosition := range stopPositions {
-		stop := stopPosition.Stop().ModelStop()
+		modelStop := stopPosition.Stop().ModelStop()
+		previousModelStop := stopPosition.Previous().ModelStop()
+		if disallowed := modelImpl.disallowedSuccessors[previousModelStop.Index()][modelStop.Index()]; disallowed {
+			return true, noPositionsHint()
+		}
 		nextModelStop := stopPosition.Next().ModelStop()
-		if disallowed := modelImpl.disallowedSuccessors[stop.Index()][nextModelStop.Index()]; disallowed {
+		if disallowed := modelImpl.disallowedSuccessors[modelStop.Index()][nextModelStop.Index()]; disallowed {
 			return true, noPositionsHint()
 		}
 	}
@@ -89,8 +93,17 @@ func (l *directPrecedencesConstraintImpl) DoesStopHaveViolations(
 ) bool {
 	modelImpl := stop.Solution().Model().(*modelImpl)
 	stopImpl := stop.(solutionStopImpl)
+	if !stop.IsFirst() {
+		previousModelStop := stopImpl.previous().modelStop()
+		if disallowed := modelImpl.disallowedSuccessors[previousModelStop.Index()][stop.ModelStopIndex()]; disallowed {
+			return true
+		}
+	}
+	if stop.IsLast() {
+		return false
+	}
 	nextModelStop := stopImpl.next().modelStop()
-	if disallowed := modelImpl.disallowedSuccessors[stop.Index()][nextModelStop.Index()]; disallowed {
+	if disallowed := modelImpl.disallowedSuccessors[stop.ModelStopIndex()][nextModelStop.Index()]; disallowed {
 		return true
 	}
 	return false

solution.go

@@ -821,9 +821,9 @@ func resetStopInterfaceCache(solution *solutionImpl) {
 		[]SolutionStop,
 		len(solution.stop),
 	)
-	for idx, value := range solution.stop {
+	for idx := range solution.stop {
 		solution.stopByIndexCache[idx] = solutionStopImpl{
-			index:    value,
+			index:    idx,
 			solution: solution,
 		}
 	}