Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce allocations for move stop generation #37

Merged
merged 1 commit into from
May 3, 2024
Merged

Reduce allocations for move stop generation #37

merged 1 commit into from
May 3, 2024

Conversation

dirkschumacher
Copy link
Contributor

@dirkschumacher dirkschumacher commented May 3, 2024 •
edited
Loading

This reduces convT trigged allocations in a hot code path.

@dirkschumacher dirkschumacher marked this pull request as ready for review May 3, 2024 11:08
merschformann
merschformann approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@merschformann merschformann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And another interface detour gone. 🥳

@dirkschumacher dirkschumacher merged commit a62e913 into develop May 3, 2024
7 checks passed
@dirkschumacher dirkschumacher deleted the ds/chore/fewer-allocs branch May 3, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merschformann merschformann merschformann approved these changes

@larsbeck larsbeck Awaiting requested review from larsbeck

@nilsbeck nilsbeck Awaiting requested review from nilsbeck

@davidrijsman davidrijsman Awaiting requested review from davidrijsman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkschumacher @merschformann