Improves value function performance #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merschformann
changed the title
merschformann
changed the title
merschformann
commented
May 15, 2024
Comment on lines
+149
to
+151
| hasTravelDistance := solutionStop.Previous().ModelStop().Location().IsValid() && | ||
| solutionStop.ModelStop().Location().IsValid() | ||
| if data, ok := solutionStop.Vehicle().ModelVehicle().VehicleType().Data().(vehicleTypeData); ok && hasTravelDistance { |
There was a problem hiding this comment.
This is the fix for the removed nil and IsValid checks (value funcs).
There was a problem hiding this comment.
@merschformann this PR will make the code also faster likely
There was a problem hiding this comment.
Should we wait on that one? Is it close?
There was a problem hiding this comment.
It is done but has not been benchmarked on larger instances yet
There was a problem hiding this comment.
I can quickly do that in our current experiments. I will also run a larger one anyway and will include it there as well. 👍
Give me some time.
merschformann
requested review from
larsbeck,
dirkschumacher,
muellerd,
sebastian-quintero,
nmisek and
davidrijsman
larsbeck
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a performance regression that surfaces under particular circumstances that was caused by extra checks in the value function and the new (more generic) stop generation logic.
Changes
factory/format.go.