Reduce allocations when applying operators #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkschumacher
force-pushed
the
ds/perf/fewer-alloc-2
branch
2 times, most recently
from
2b08ba3 to
279d001
Compare
dirkschumacher
requested review from
larsbeck,
merschformann,
sebastian-quintero and
davidrijsman
dirkschumacher
force-pushed
the
ds/perf/fewer-alloc-2
branch
from
279d001 to
e611b0c
Compare
larsbeck
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces some allocations when applying operators:
solveInformation.solveOperatorsis now reused which implies that any listener needs to make copies of the data if they want to retain them. I believe this is reasonable. What are your thoughts?s.SolveOperators()creates a new slice every time the operators are ranged over. This is not necessary IMHO.