Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SolutionVehicle iface to struct #53

Merged
merged 4 commits into from
May 19, 2024
Merged

SolutionVehicle iface to struct #53

merged 4 commits into from
May 19, 2024

Conversation

dirkschumacher
Copy link
Contributor

@dirkschumacher dirkschumacher commented May 19, 2024 •
edited
Loading

This converts the SolutionVehicle to a struct and adds an IsZero() function to check for nil values. Benchmarks are looking good.

@dirkschumacher dirkschumacher marked this pull request as ready for review May 19, 2024 13:48
@dirkschumacher dirkschumacher merged commit 918df10 into develop May 19, 2024
7 checks passed
@dirkschumacher dirkschumacher deleted the ds/perf/iface-struct branch May 19, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsbeck larsbeck larsbeck approved these changes

@merschformann merschformann Awaiting requested review from merschformann

@sebastian-quintero sebastian-quintero Awaiting requested review from sebastian-quintero

@davidrijsman davidrijsman Awaiting requested review from davidrijsman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkschumacher @larsbeck