Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping default max time horizon to 6 months #79

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

merschformann
Copy link
Member

@merschformann merschformann commented Dec 16, 2024

Description

Bumps the recently introduced max time horizon to 6 months in order to be less restrictive.
Furthermore, aligns the test app style with the new version from community-apps.

Changes

  • Increases the default max time horizon for an input to 6 months (15552000 seconds).
  • Aligns test app with latest version from community-apps.
  • Splits golden file tests per language in .go.golden and .python.golden to account for diverging output formats.

@merschformann merschformann marked this pull request as ready for review December 16, 2024 09:44
@merschformann merschformann force-pushed the merschformann/adjust-max-time-horizon branch from cfe33fb to 87bf099 Compare December 16, 2024 10:17
Copy link
Member

@sebastian-quintero sebastian-quintero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10k lines changed, lgtm.

@merschformann
Copy link
Member Author

10k lines changed, lgtm.

Added even 😬

@merschformann merschformann merged commit f0dc5de into develop Dec 16, 2024
33 checks passed
@merschformann merschformann deleted the merschformann/adjust-max-time-horizon branch December 16, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants