Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FetchPairs: support traversing #286

Closed
wants to merge 8 commits into from

Conversation

robskr
Copy link
Contributor

@robskr robskr commented Mar 21, 2018

Should solve #147. Naming probably needs some tweaks.

@hrach
Copy link
Member

hrach commented Apr 7, 2018

Hi, thanks for the contribution! It's great.
My questions/thoughts:

  • we have quite similar code in ArrayCollectionHelper, but there are some differences
  • you don't handle hasMany relationships - in any way. I'm ok probably with not supporting, we may throw an exception.
  • you simply iterate over the result, but in fact some "value" may be and and "object" and not an entity and this method will allow iterate over it. This is something what is handled in ArrayCollectionHelper which check this

What do you think?

@hrach hrach added the feature label Apr 7, 2018
@hrach
Copy link
Member

hrach commented Oct 15, 2018

Ok, I have reworked your solution a little: #313

@hrach hrach closed this Oct 15, 2018
@hrach
Copy link
Member

hrach commented Oct 15, 2018

Thanks for your work!

@robskr
Copy link
Contributor Author

robskr commented Oct 16, 2018

Dammit, I missed your first comment. I am sorry for not finishing the work :(

Thank you for completing the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants