Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove auspice-client/customisations/splash.js #1090

Open
4 tasks
victorlin opened this issue Dec 11, 2024 · 3 comments
Open
4 tasks

Remove auspice-client/customisations/splash.js #1090

victorlin opened this issue Dec 11, 2024 · 3 comments

Comments

@victorlin
Copy link
Member

victorlin commented Dec 11, 2024

nextstrain.org now uses its own dataset listing UI, so this file can probably be removed.

Tasks:

  • /fetch URLs can still end up at the auspice splash page
  • URLs containing "narrative" can still end up at the auspice splash page
  • failure to GET /charon/getDataset can end up at the Auspice splash page
  • remove the file once it can no longer be accessed

(some tasks from #310 (comment))

@tsibley
Copy link
Member

tsibley commented Dec 13, 2024

I added another way to get to the Auspice splash page to the task list above, e.g.

image

@victorlin
Copy link
Member Author

https://next.nextstrain.org/seasonal-flu/h3n2/ha/6m works for me. Something like https://next.nextstrain.org/seasonal-flu/h3n2/ha/1m serves a 404 page instead.

I tried a few other URLs and couldn't get this splash component to load. Does anyone have a URL that loads it?

@tsibley
Copy link
Member

tsibley commented Jan 15, 2025

@victorlin I was showing an example of the way to get the splash page that I added to the task list at the top:

failure to GET /charon/getDataset can end up at the Auspice splash page

There's a lot of ways this can happen in real usage, but you can replicate it one way by:

  1. Visit https://next.nextstrain.org/seasonal-flu/h3n2/ha/2y
  2. Disconnect from the network (e.g. turn off wifi, unplug your ethernet, turn on airplane mode, ifconfig eth0 down, go into "offline mode" in your browser/dev tools, whatever)
  3. Change sidebar dropdown dataset selector from 2y → 6m.
  4. Watch splash page load because the /charon/getDataset request failed.

You can also use request blocking in browser dev tools to block the /charon/getDataset requests and see this behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants