-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove autoCapitalize to prevent Firefox warning #3376
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 508086d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughA patch was introduced to the Changes
Sequence Diagram(s)N/A Assessment against linked issues
Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- packages/components/date-input/src/date-input-segment.tsx (1 hunks)
Additional context used
Biome
packages/components/date-input/src/date-input-segment.tsx
[error] 31-31: Avoid the delete operator which can impact performance.
Unsafe fix: Use an undefined assignment instead.
(lint/performance/noDelete)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please include a changeset
- wondering if it should be marked as v2.4.3 (bug fix release) instead? It seems there is no breaking change.
In linear, it was v2.5.0, but v2.4.3 certainly looks good. I will leave the rest to Junior to decide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .changeset/chatty-pianos-run.md (1 hunks)
Files skipped from review due to trivial changes (1)
- .changeset/chatty-pianos-run.md
Closes #3297
📝 Description
This bug occurs because react-aria sets
autoCapitalize: 'off'
on each segment of the DateInput , but in Firefox, it defaults to 'none'. This discrepancy between server side rendering and client-side rendering results in a warning. In Safari and Chrome, it remains 'off', so no warning is displayed. Since the DateInput hasinput-mode=numeric
, which already shows a numeric keyboard, theautoCapitalize
setting is unnecessary.⛳️ Current behavior (updates)
A warning is displayed when rendering a component with DateInput in Firefox.
🚀 New behavior
No warning is displayed.
💣 Is this a breaking change (Yes/No):
No.
📝 Additional Information
Summary by CodeRabbit
autoCapitalize
property from theDateInputSegment
component to resolve compatibility issues in Firefox.