fix(calendar): arrows changing order when html has dir="rtl" #3656
Conversation
…rse to arrows for rtl layout support
🦋 Changeset detectedLatest commit: 4b34d6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@ameybh is attempting to deploy a commit to the NextUI Inc Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThis update enhances the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- .changeset/slow-forks-nail.md (1 hunks)
- packages/components/calendar/src/calendar-base.tsx (4 hunks)
- packages/core/theme/src/components/calendar.ts (1 hunks)
Additional comments not posted (3)
.changeset/slow-forks-nail.md (1)
1-5: Changeset file looks good.The changeset correctly describes the fix for the arrow keys order in RTL mode.
packages/components/calendar/src/calendar-base.tsx (1)
Line range hint
72-86: Simplified icon rendering logic is effective.The removal of locale-based conditions for icon rendering reduces complexity and potential errors.
However, verify if the removal of
useLocaleaffects other parts of the codebase.packages/core/theme/src/components/calendar.ts (1)
13-24: CSS class changes enhance RTL support.The introduction of specific ordering classes and
rtl:flex-row-reverseimproves RTL layout handling.Verify if the CSS class changes are consistently applied across the component.
Verification successful
CSS class changes verified for RTL support in
calendar.ts.The CSS classes
order-1,order-2,order-3, andrtl:flex-row-reverseare consistently applied in thecalendar.tscomponent, enhancing RTL layout handling as intended. No inconsistencies were found within this component.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistent application of CSS class changes for RTL support. # Test: Search for the usage of `order-1`, `order-2`, `order-3`, and `rtl:flex-row-reverse`. Expect: Consistent usage across the component. rg --type ts 'order-1|order-2|order-3|rtl:flex-row-reverse'Length of output: 8986
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- .changeset/slow-forks-nail.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .changeset/slow-forks-nail.md
Closes #3641
Closes #3642
📝 Description
⛳️ Current behavior (updates)
As described in #3641, currently, if the html has
dirattribute equal tortl, the arrow keys look incorrect.🚀 New behavior
Added
ordertoprevButton,nextButtonandheader. Addedrtl:flex-row-reversetoheaderWrapper.The prev button should always be a left arrow and the next button should always be a right arrow, hence removed condition that changed arrow type based on locale direction.
Calendar with
dir="rtl"Date Picker with
dir="rtl"Date picker in Arabic
💣 Is this a breaking change (Yes/No):
No.
Summary by CodeRabbit
New Features
Bug Fixes
Style