Add Nexus-Operation-Id and Nexus-Link headers to callback definition #12
Conversation
SPEC.md
Outdated
| - Include the `Nexus-Operation-Id` header and any `Nexus-Link` headers for resources associated with this operation to | ||
| support completing asynchronous operations before the response to StartOperation is received. |
There was a problem hiding this comment.
I assume when we allow users to have external callbacks this won't expose any security risks by giving the callback internal information like a workflow that may be backing an operation? Or at that time we will have some way to hide the workflow link if a Nexus endpoint doesn't want to expose it?
There was a problem hiding this comment.
Yes, there needs to be a knob for users to decide if they want to expose caller and handler information in Temporal. For now, we're limited to same account traffic and the consensus seems to be to always expose.
There was a problem hiding this comment.
We should also include the Nexus-Operation-Start-Time header to be able to recreate the full started event.
SPEC.md
Outdated
| @@ -306,6 +306,10 @@ For invoking a callback URL: | |||
| - Issue a POST request to the caller-provided URL. | |||
| - Include any callback headers supplied in the originating StartOperation request, stripping away the `Nexus-Callback-` | |||
| prefix. | |||
| - Include the `Nexus-Operation-Id` header, `Nexus-Operation-Start-Time` and any `Nexus-Link` headers for resources | |||
| associated with this operation to support completing asynchronous operations before the response to StartOperation is | |||
| received. `Nexus-Operation-Start-Time` should be in a valid HTTP/1.1 format. If is omitted, the time the completion is | |||
There was a problem hiding this comment.
Could you clarify and possibly link here? https://www.rfc-editor.org/rfc/rfc5322.html#section-3.3
Added
Nexus-Operation-IdandNexus-Linkheaders to callback description. These are needed to support completing async operations before the start operation response is received.