Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "--experimental_allow_proto3_optional" flag to protoc config for Ubuntu compatibility. #1341

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

meta-light
Copy link

Also cleaned up that pesky .DS_Store file

@b3zn0gim
Copy link

I ended up doing the same, glad that someone else already made a PR 🍻

@ashus7
Copy link

ashus7 commented Feb 20, 2025

Error: protoc failed: orchestrator.proto:83:12: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.
orchestrator.proto:86:12: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.

@ashus7
Copy link

ashus7 commented Feb 20, 2025

@b3zn0gim
@meta-light
rustc 1.85.0-nightly (45d11e51b 2025-01-01)
/home/ashu/.nexus/network-api exists. Updating.
Saved working directory and index state WIP on (no branch): 9568a30 fix: CLI fetch inputs (#1397)
HEAD is now at 9568a30 fix: CLI fetch inputs (#1397)
Compiling nexus-network v0.5.5 (/home/ashu/.nexus/network-api/clients/cli)
error: failed to run custom build command for nexus-network v0.5.5 (/home/ashu/.nexus/network-api/clients/cli)

Caused by:
process didn't exit successfully: /home/ashu/.nexus/network-api/clients/cli/target/release/build/nexus-network-ffaee377ad2254b7/build-script-build (exit status: 1)
--- stdout
cargo:rerun-if-changed=proto/orchestrator.proto
cargo:rerun-if-changed=build.rs
Current dir: "/home/ashu/.nexus/network-api/clients/cli"
Looking for proto file at: "/home/ashu/.nexus/network-api/clients/cli/proto/orchestrator.proto"
protoc is installed and accessible.
Output directory src/proto exists.
Error compiling protobuf files: protoc failed: orchestrator.proto:83:12: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.
orchestrator.proto:86:12: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.
orchestrator.proto:89:12: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.
orchestrator.proto:92:12: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.

Error: protoc failed: orchestrator.proto:83:12: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.
orchestrator.proto:86:12: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.
orchestrator.proto:89:12: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.
orchestrator.proto:92:12: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.

--- stderr
Error: Custom { kind: Other, error: "protoc failed: orchestrator.proto:83:12: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.\norchestrator.proto:86:12: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.\norchestrator.proto:89:12: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.\norchestrator.proto:92:12: Explicit 'optional' labels are disallowed in the Proto3 syntax. To define 'optional' fields in Proto3, simply remove the 'optional' label, as fields are 'optional' by default.\n" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants