-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve description of the value of the default attribute #1022
Conversation
prjemian
commented
Mar 7, 2022
•
edited
Loading
edited
- FIX @default is a step by step process instead of a direct jump (should be better documented) #1003
- REF Is 'default' attribute value an absolute reference or a relative one? #1063
- REF Base Class and Application Definition development questions NIAC#107
Is there any other documentation to be revised? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I added some comments related to keeping the docs HDF5 agnostic.
I also see you often make the distinction between a field and a link to field (e.g. either as a NeXus field or as a link to a NeXus field
). I guess this is done all over the documentation but imo this is an HDF5 feature which has nothing to do with the NeXus standard. But anyway, that should be discussed elsewhere.
I am in favor of woutdenolfs more general wording. |
@benajamin notes that this legacy text is out of date: definitions/base_classes/NXdata.nxdl.xml Lines 181 to 184 in 66d9168
Look at this code (in <attribute name="auxiliary_signals">
``signal`` attribute). Each auxiliary signal needs to be of definitions/base_classes/NXdata.nxdl.xml Lines 52 to 64 in 5798a56
|
Also, NXentry no longer requires a NXdata group. |
I agree in staying general, but I don't know if it is fair to say that only HDF5 has links. |
@benajamin @woutdenolf This is ready for review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from some technical fixes, it seems all good now. Thanks for the hard work!
A small additional comment: I noticed you used the phrase
The value of the
default
attribute :ref:names <validItemName>
an
existing child of this group
The link to validItemName
is not really needed imo but I guess it doesn't hurt either.
WARNING: Failed to create a cross reference. A title or caption not found: find-plottable-data-v3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the reviews! |