Fairmat 2024: base classes to describe computational geometry #1421
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,7 +52,8 @@ | |
| Computational geeometry description of a half-edge data structure. | ||
|
|
||
| Such a data structure can be used to efficiently circulate around faces | ||
PeterC-DLS marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| and iterate over vertices of a planar graph. The data structure is also | ||
| known as a doubly connected edge list. | ||
| </doc> | ||
| <field name="dimensionality" type="NX_POSINT" units="NX_UNITLESS"> | ||
| <doc> | ||
|
|
@@ -79,15 +80,10 @@ | |
| irrespectively whether edges are shared across faces or not. | ||
| </doc> | ||
| <dimensions rank="1"> | ||
| <dim index="1" value="n_he"/> | ||
| </dimensions> | ||
| </field> | ||
| <field name="identifier_vertex_offset" type="NX_INT" units="NX_UNITLESS"> | ||
| <doc> | ||
| Integer offset whereby the identifier of the first member | ||
| of the vertices differs from zero. | ||
|
|
@@ -96,7 +92,7 @@ | |
| Inspect the definition of :ref:`NXcg_primitive` for further details. | ||
| </doc> | ||
| </field> | ||
| <field name="identifier_edge_offset" type="NX_INT" units="NX_UNITLESS"> | ||
| <doc> | ||
| Integer offset whereby the identifier of the first member | ||
| of the edges differs from zero. | ||
|
|
@@ -105,7 +101,7 @@ | |
| Inspect the definition of :ref:`NXcg_primitive` for further details. | ||
| </doc> | ||
| </field> | ||
| <field name="identifier_face_offset" type="NX_INT"> | ||
| <doc> | ||
| Integer offset whereby the identifier of the first member | ||
| of the faces differs from zero. | ||
|
|
@@ -114,7 +110,7 @@ | |
| Inspect the definition of :ref:`NXcg_primitive` for further details. | ||
| </doc> | ||
| </field> | ||
| <!--therefore, identifier_ -vertex, -face, -half_edge are implicit--> | ||
| <field name="position" type="NX_NUMBER" units="NX_ANY"> | ||
| <doc> | ||
| The position of the vertices. | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,13 +54,13 @@ multiple vertices possible with the same point coordinates but different names.- | |
|
|
||
| Each polyline is built from a sequence of vertices (points with identifiers). | ||
| Each polyline must have a start and an end point. | ||
| The sequence describes the traversal along the polyline when | ||
| walking from the first to the last vertex. | ||
| </doc> | ||
| <field name="depends_on" type="NX_CHAR"> | ||
| <doc> | ||
| Reference to an instance of :ref:`NXcg_point` which defines the | ||
| location of the vertices that are referred to in this | ||
| NXcg_polyline instance. | ||
| </doc> | ||
| </field> | ||
|
|
@@ -78,8 +78,6 @@ multiple vertices possible with the same point coordinates but different names.- | |
| <doc> | ||
| The total number of vertices of each polyline, irrespectively | ||
| whether vertices are shared by vertices or not. | ||
| </doc> | ||
| <dimensions rank="1"> | ||
| <dim index="1" value="c"/> | ||
|
|
@@ -118,9 +116,9 @@ they share the same position in space but have different identifiers.--> | |
| Sequence of identifier for vertices how they build each polyline. | ||
|
|
||
| A trivial example is a set with two polylines with three vertices each. | ||
| If the polylines meet at a vertex (assume for example that the second vertex | ||
| is shared and marking the junction between the two polylines), it is possible | ||
| that there are only five unique positions. This suggests to store five | ||
| unique vertices. | ||
|
|
||
| A non-trivial example is a set with several polylines. Assume that each | ||
|
|
@@ -131,9 +129,9 @@ they share the same position in space but have different identifiers.--> | |
| followed by the second vertex of the first polyline, until the last vertex | ||
| of the first polyline. | ||
| Thereafter, the first vertex of the second polyline, and so on and so forth. | ||
| Using the (cumulated) counts in number_of_vertices (:math:`n^v_i`), | ||
| the vertices of the N-th polyline can be accessed on the array | ||
| index interval :math:`[\sum_{i=0}^{i=N-1} n^v_i, \sum_{i=0}^{i=N} n^v_i]`. | ||
| </doc> | ||
| <dimensions rank="1"> | ||
| <dim index="1" value="n_total"/> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -51,17 +51,18 @@ | |||||
| </field> | ||||||
| <field name="dimensionality" type="NX_POSINT" units="NX_UNITLESS"> | ||||||
| <doc> | ||||||
| The dimensionality of the primitive set with value up to d. | ||||||
| </doc> | ||||||
| <enumeration> | ||||||
| <!-- add when 1521 has been merged open="true"--> | ||||||
| <item value="1"/> | ||||||
| <item value="2"/> | ||||||
| <item value="3"/> | ||||||
PeterC-DLS marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| </enumeration> | ||||||
| </field> | ||||||
| <field name="cardinality" type="NX_POSINT" units="NX_UNITLESS"> | ||||||
| <doc> | ||||||
| The cardinality of the primitive set. Value should be equal to c. | ||||||
| </doc> | ||||||
| </field> | ||||||
| <field name="identifier_offset" type="NX_INT" units="NX_UNITLESS"> | ||||||
|
|
@@ -92,7 +93,7 @@ | |||||
| </field> | ||||||
| <field name="center" type="NX_NUMBER" units="NX_ANY"> | ||||||
| <doc> | ||||||
| The center of each primitive | ||||||
| </doc> | ||||||
| <dimensions rank="2"> | ||||||
| <dim index="1" value="c"/> | ||||||
|
|
@@ -109,7 +110,7 @@ | |||||
| </field> | ||||||
| <field name="shape" type="NX_NUMBER" units="NX_LENGTH"> | ||||||
| <doc> | ||||||
| Shape of each primitive | ||||||
| </doc> | ||||||
| <dimensions rank="2"> | ||||||
| <dim index="1" value="c"/> | ||||||
|
|
@@ -118,9 +119,9 @@ | |||||
| </field> | ||||||
| <field name="length" type="NX_NUMBER" units="NX_LENGTH"> | ||||||
| <doc> | ||||||
| Length of each primitive | ||||||
|
|
||||||
| Often the term is associated with the assumption that one | ||||||
| edge is parallel to an axis of the coordinate system. | ||||||
| </doc> | ||||||
| <dimensions rank="1"> | ||||||
|
|
@@ -129,8 +130,21 @@ | |||||
| </field> | ||||||
| <field name="width" type="NX_NUMBER" units="NX_LENGTH"> | ||||||
| <doc> | ||||||
| Width of each primitive | ||||||
|
|
||||||
| Often the term is associated with the assumption that one | ||||||
| edge is parallel to an axis of the coordinate system. | ||||||
| </doc> | ||||||
| <dimensions rank="1"> | ||||||
| <dim index="1" value="c"/> | ||||||
| </dimensions> | ||||||
| </field> | ||||||
| <field name="height" type="NX_NUMBER" units="NX_LENGTH"> | ||||||
| <doc> | ||||||
| Height of each primitive | ||||||
|
|
||||||
| Often the term is associated with the assumption that one | ||||||
| edge is parallel to an axis of the coordinate system. | ||||||
| </doc> | ||||||
| <dimensions rank="1"> | ||||||
| <dim index="1" value="c"/> | ||||||
|
|
@@ -144,11 +158,13 @@ | |||||
| <dim index="1" value="c"/> | ||||||
| </dimensions> | ||||||
| </field> | ||||||
| <field name="volume" type="NX_NUMBER" units="NX_ANY"> | ||||||
| <doc> | ||||||
| Volume of each primitive. | ||||||
PeterC-DLS marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
|
||||||
| Set to NaN if does not apply for primitives for which is_closed is False. | ||||||
| Volume is an N-D concept for values of dimensionality larger than 1, | ||||||
| Area is a an alias for the two-dimensional case. | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| </doc> | ||||||
| <dimensions rank="1"> | ||||||
| <dim index="1" value="c"/> | ||||||
|
|
@@ -182,16 +198,16 @@ | |||||
| Do the primitives define a mesh. | ||||||
| </doc> | ||||||
| </field> | ||||||
| <field name="is_triangle_mesh" type="NX_BOOLEAN"> | ||||||
| <doc> | ||||||
| Do the primitives define a triangle mesh or not. | ||||||
| </doc> | ||||||
| </field> | ||||||
| <field name="is_surface_mesh" type="NX_BOOLEAN"> | ||||||
| <doc> | ||||||
| Do the primitives discretize the surface of an object or not. | ||||||
| </doc> | ||||||
| </field> | ||||||
| <field name="is_geodesic_mesh" type="NX_BOOLEAN"> | ||||||
PeterC-DLS marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| <doc> | ||||||
| Do the primitives define a geodesic mesh or not. | ||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,7 +60,7 @@ rather make this a set of vectors, irrespective whether these are unit or not--> | |
| </field> | ||
| <field name="orientation" type="NX_INT" units="NX_UNITLESS"> | ||
| <doc> | ||
| An indicator which details the orientation of each normal vector | ||
| in relation to its primitive, assuming the object is viewed | ||
| from a position outside the object. | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented