-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested improvements to the NXdata base class definition #602
Open
rayosborn
wants to merge
20
commits into
nexusformat:main
Choose a base branch
from
rayosborn:osborn-suggestions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+110
−109
Open
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
aee3827
Replace 'dataset' with 'field'
rayosborn 619d077
Rename VARIABLE and AXISNAME
rayosborn 7a0493c
Removed redundant fields
rayosborn b91e4d7
Removed redundant text
rayosborn 0dec12d
Changed 'mandatory' to 'recommended'
rayosborn 088ef4f
Update definition of uncertainties
rayosborn c0a593d
Add use of bin boundaries
rayosborn b81ae69
Miscellaneous edits
rayosborn 59e55a4
Fix indentation
rayosborn 4bac172
Fix typos and improve wording
rayosborn 4c21ea8
Amend wording about uncertainties
rayosborn 6b9413b
Fix indentation
rayosborn 0359402
Merge branch 'master' of https://github.com/nexusformat/definitions i…
rayosborn 4b7ccb3
Merge branch 'master' of https://github.com/nexusformat/definitions i…
rayosborn 81634f1
Merge branch 'main' into osborn-suggestions
prjemian 6ce74b0
DOC #602 reST syntax
prjemian 6c56a38
Merge branch 'osborn-suggestions' of https://github.com/rayosborn/def…
prjemian 4f7e06d
DOC #602 indentation
prjemian 9e1b035
CI #602 spelling
prjemian 5c37cbb
DOC #602 AXISNAME -> AXIS per commit 619d077
prjemian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Replace 'dataset' with 'field'
Data sets can mean a multitude of things in different contexts. For example, in many data catalogs, data sets refer to collections of data objects. Even within this file, some might construe 'dataset' to refer to the plottable data. However, there are many uses of the word 'field', which is less ambiguous, so I would propose that this is used wherever we are referring to an item in the group.
commit aee3827402f3d67b05b559eaf96d0835a74ad594
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that link goes nowhere