Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: onFocus and onClick in Picklist triggered when it should not #2528

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix: onFocus and onClick in Picklist triggered when it should not #2528

wants to merge 8 commits into from

Conversation

adrianestevez1
Copy link
Contributor

fix: #2517

Changes proposed in this PR:

-fix: onFocus and onClick in Picklist triggered when it should not

@nexxtway/react-rainbow

@commit-lint
Copy link

commit-lint bot commented Nov 4, 2022 •
edited
Loading

Bug Fixes

  • onFocus and onClick in Picklist triggered when it should not (22321d0)
  • onFocus and onClick in Picklist triggered when it should not (8bcd692)
  • onFocus and onClick in Picklist triggered when it should not (0b0a92c)
  • onFocus and onClick in Picklist triggered when it should not (ad65d5a)
  • onFocus and onClick in Picklist triggered when it should not (4e6f651)

Contributors

LeandroTorresSicilia

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2022 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ LeandroTorresSicilia
❌ Adrian Estevez

Adrian Estevez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit eabf37f):

https://react-rainbow--pr2528-fix-onfocus-on-pickl-qu5ciyj8.web.app

(expires Thu, 29 Dec 2022 19:52:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2de6d670498a0a515484c5637b13d0215372df83

LeandroTorresSicilia
LeandroTorresSicilia reviewed Dec 13, 2022
View reviewed changes
src/components/Picklist/readme.md Outdated
@@ -22,6 +22,8 @@ const initialState = { value: { name: 'option 3', label: 'Central Park' } };
onChange={value => setState({ value })}
value={state.value}
label="Select Building"
onClick={() => console.log('click')}
onFocus={() => console.log('focus')}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these console

@codeclimate
Copy link

codeclimate bot commented Dec 22, 2022

Code Climate has analyzed commit eabf37f and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeandroTorresSicilia LeandroTorresSicilia LeandroTorresSicilia left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: onFocus and onClick in Picklist triggered when it should not
3 participants
@adrianestevez1 @CLAassistant @LeandroTorresSicilia