Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v2.14.1 #91

Merged
merged 7 commits into from
May 10, 2024
Merged

Important! Template update for nf-core/tools v2.14.1 #91

merged 7 commits into from
May 10, 2024

Conversation

nf-core-bot
Copy link
Member

Version 2.14.1 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.14.1 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v2.14.1 release page.

This was referenced May 9, 2024
Merged
Closed
@maxulysse
Copy link
Member

@nf-core-bot fix linting pretty please 🙏

@github-actions GitHub Actions
Copy link

github-actions bot commented May 10, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 1d872ef

+| ✅ 194 tests passed       |+
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-10 13:13:00

asp8200
asp8200 reviewed May 10, 2024
View reviewed changes
.github/CONTRIBUTING.md
You have the option to test your changes locally by running the pipeline. For receiving warnings about process selectors and other `debug` information, it is recommended to use the debug profile. Execute all the tests with the following command:

```bash
nf-test test --profile debug,test,docker --verbose
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sure that works for bamtofastq but let me try.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

$ nf-test test --profile debug,test,docker --verbose

🚀 nf-test 0.8.4
https://code.askimed.com/nf-test
(c) 2021 - 2024 Lukas Forer and Sebastian Schoenherr

Warning: This pipeline has no nf-test config file.
Error: No tests or test directories containing scripts that end with *.test provided.

asp8200
asp8200 reviewed May 10, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@asp8200
Copy link
Contributor

asp8200 commented May 10, 2024

All tests passing 🥳 👏👏

@maxulysse @asp8200
Update CHANGELOG.md
1d872ef 
Co-authored-by: Anders Sune Pedersen <[email protected]>
@asp8200 asp8200 merged commit 3e672f8 into dev May 10, 2024
18 checks passed
@maxulysse maxulysse deleted the nf-core-template-merge-2.14.1 branch May 10, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asp8200 asp8200 asp8200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nf-core-bot @maxulysse @asp8200