Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes #339

Merged
merged 24 commits into from
Apr 18, 2023
Merged

Some fixes #339

merged 24 commits into from
Apr 18, 2023

Conversation

JoseEspinosa
Copy link
Member

@JoseEspinosa JoseEspinosa commented Apr 17, 2023 •
edited
Loading

Add back skip_spp parameter (fixes #311)
Install all available subworkflows in nf-core and refactor the code accordingly
Update bowtie2/align to fix the download of the container by tools (fixes #318)

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@github-actions
Copy link

github-actions bot commented Apr 17, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit aece0fb

+| ✅ 157 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-04-18 20:49:47

@JoseEspinosa JoseEspinosa marked this pull request as ready for review April 18, 2023 15:24
@JoseEspinosa JoseEspinosa mentioned this pull request Apr 18, 2023
Closed
bjlang
bjlang reviewed Apr 18, 2023
View reviewed changes
workflows/chipseq.nf Outdated
Comment on lines 312 to 317
BAM_FILTER_BAMTOOLS
.out
.bam
.map {
[ it[0], it[1], [] ]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A view that I forgot to remove, thanks for spotting it!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix in 6a75945

bjlang
bjlang approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@bjlang bjlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JoseEspinosa JoseEspinosa merged commit 3b94a84 into nf-core:dev Apr 18, 2023
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjlang bjlang bjlang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoseEspinosa @bjlang