Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates #352

Merged
merged 15 commits into from
Jun 28, 2023
Merged

Updates #352

merged 15 commits into from
Jun 28, 2023

Conversation

JoseEspinosa
Copy link
Member

@JoseEspinosa JoseEspinosa commented Jun 23, 2023 •
edited
Loading

Some fixes:

Fix blacklist logic when provided as a file (and other similar files)
Remove parameter from plot_macs2_qc module logic
Add ext.when to local modules
Rearrange modules.config accordingly to above-mentioned changes

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @JoseEspinosa,

It looks like this pull-request is has been made against the JoseEspinosa/nf-core-chipseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the JoseEspinosa/nf-core-chipseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Jun 23, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2a5f3f4

+| ✅ 159 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-28 10:59:52

@JoseEspinosa JoseEspinosa changed the base branch from master to dev June 26, 2023 06:22
@JoseEspinosa JoseEspinosa marked this pull request as ready for review June 26, 2023 18:17
bjlang
bjlang reviewed Jun 27, 2023
View reviewed changes
conf/modules.config Show resolved Hide resolved
conf/modules.config Outdated Show resolved Hide resolved
conf/modules.config Outdated Show resolved Hide resolved
@JoseEspinosa JoseEspinosa merged commit 3cff26f into nf-core:dev Jun 28, 2023
11 checks passed
@JoseEspinosa JoseEspinosa deleted the updates branch June 28, 2023 11:37
@JoseEspinosa JoseEspinosa restored the updates branch June 28, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjlang bjlang bjlang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoseEspinosa @bjlang