Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor + updates to gens and germlinecnvcaller #24

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

ramprasadn
Copy link
Contributor

@ramprasadn ramprasadn commented Apr 5, 2024

This PR

  • Updates germlinecnvcaller subworkflow to use mappability and segmental duplications track
  • Updates germlinecnvcaller and gens subworkflows to use custom names for panel of normals.
  • Addresses Add igenomes support #23

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/createpanelrefs branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@ramprasadn ramprasadn changed the title Refactor Refactor + updates to gens and germlinecnvcaller Apr 6, 2024
@ramprasadn ramprasadn marked this pull request as ready for review April 6, 2024 14:58
Comment on lines +18 to +19
ch_user_dict // channel: [optional] [ val(meta), path(dict) ]
ch_user_fai // channel: [optional] [ val(meta), path(fai) ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This worklfow can also generate these files if not provided by the user so just to differentiate user given and pipeline generated dict and fai, I use user here :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?
I'd assume that either user generated or pipeline generated fai/dict from the same fasta file should correspond, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files should correspond, yes. This is more for code readability, because I do this later

ch_user_dict
.mix(PICARD_CREATESEQUENCEDICTIONARY.out.reference_dict)
.collect()
.set { ch_dict }
ch_user_fai
.mix(SAMTOOLS_FAIDX.out.fai)
.collect()
.set { ch_fai }

Copy link
Member

@maxulysse maxulysse Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

OK for now, but let's move this bit outside of this subworkflow and create a general prepare genome subworkflow later on

@maxulysse maxulysse merged commit 740a7cb into nf-core:dev Apr 8, 2024
8 checks passed
@ramprasadn ramprasadn deleted the refactor branch April 8, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants