-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor + updates to gens and germlinecnvcaller #24
Conversation
ch_user_dict // channel: [optional] [ val(meta), path(dict) ] | ||
ch_user_fai // channel: [optional] [ val(meta), path(fai) ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why user
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This worklfow can also generate these files if not provided by the user so just to differentiate user given and pipeline generated dict and fai, I use user
here :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
I'd assume that either user generated or pipeline generated fai/dict from the same fasta file should correspond, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The files should correspond, yes. This is more for code readability, because I do this later
createpanelrefs/subworkflows/local/germlinecnvcaller_cohort.nf
Lines 36 to 44 in 7a8d930
ch_user_dict | |
.mix(PICARD_CREATESEQUENCEDICTIONARY.out.reference_dict) | |
.collect() | |
.set { ch_dict } | |
ch_user_fai | |
.mix(SAMTOOLS_FAIDX.out.fai) | |
.collect() | |
.set { ch_fai } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see.
OK for now, but let's move this bit outside of this subworkflow and create a general prepare genome subworkflow later on
This PR
PR checklist
nf-core lint
).nf-test test main.nf.test -profile test,docker
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).