Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL1: Release 2.5.0 - Bopfingen #1032

Merged
merged 32 commits into from
Nov 7, 2023
Merged

DSL1: Release 2.5.0 - Bopfingen #1032

merged 32 commits into from
Nov 7, 2023

Conversation

TCLamnidis
Copy link
Collaborator

@TCLamnidis TCLamnidis commented Nov 1, 2023

Better RG information generated by all mappers.
Bumped MultiQC. Faster processing, and always produces general_stats_table.txt.
MapDamage2 can now be used for damage calculation. Read number limit available for large input files.
Fixed a bug where genotyping and damage calculation would not run if using bowtie2 and no fasta index was provided.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@TCLamnidis TCLamnidis added the DSL1 label Nov 1, 2023
@TCLamnidis TCLamnidis requested review from jfy133 and aidaanva November 1, 2023 17:46
@TCLamnidis TCLamnidis changed the title Release 2.5.0 DSL1: Release 2.5.0 Nov 1, 2023
@TCLamnidis TCLamnidis changed the title DSL1: Release 2.5.0 DSL1: Release 2.5.0 - Bopfingen Nov 1, 2023
@TCLamnidis TCLamnidis requested a review from merszym November 2, 2023 15:19
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
main.nf Outdated Show resolved Hide resolved
nextflow_schema.json Outdated Show resolved Hide resolved
@TCLamnidis TCLamnidis requested a review from maxulysse November 3, 2023 09:28
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: James A. Fellows Yates <[email protected]>
nextflow_schema.json Outdated Show resolved Hide resolved
@TCLamnidis TCLamnidis merged commit a2c9f87 into master Nov 7, 2023
7 of 9 checks passed
@TCLamnidis TCLamnidis deleted the patch branch November 7, 2023 12:44
@TCLamnidis TCLamnidis restored the patch branch November 7, 2023 12:44
Copy link

Markdown linting is failing

To keep the code consistent with lots of contributors, we run automated code consistency checks.
To fix this CI test, please run:

  • Install markdownlint-cli
  • Fix the markdown errors
    • Automatically: markdownlint . --config .github/markdownlint.yml --fix
    • Manually resolve anything left from markdownlint . --config .github/markdownlint.yml

Once you push these changes the test should pass, and you can hide this comment 👍

We highly recommend setting up markdownlint in your code editor so that this formatting is done automatically on save. Ask about it on Slack for help!

Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants