Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bedtools coverage in DSL1 #1036

Closed
wants to merge 1 commit into from

Conversation

IdoBar
Copy link
Contributor

@IdoBar IdoBar commented Dec 12, 2023

Remove the -sorted flag so bedtools won't assume that the reference genome file is sorted.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/eager/tree/master/.github/CONTRIBUTING.md)
    • If necessary, also make a PR on the nf-core/eager branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Remove the `-sorted` flag so `bedtools` won't assume that the reference genome file is sorted.
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @IdoBar,

It looks like this pull-request is has been made against the IdoBar/eager master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the IdoBar/eager dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@TCLamnidis
Copy link
Collaborator

Hi Ido!

Thanks for the PR. I will look into it and try to incorporate it into a patch release with a couple more small changes in the beginning of next year.

@TCLamnidis TCLamnidis changed the base branch from master to patch-2.5.1 February 9, 2024 09:20
@TCLamnidis
Copy link
Collaborator

Had another look into why we added that flag #824 . It seems without it, the memory footprint of bedtools coverage is extremely large. I think I will instead add an option to REMOVE the -sorted flag.

@TCLamnidis TCLamnidis mentioned this pull request Feb 16, 2024
7 tasks
@TCLamnidis
Copy link
Collaborator

Changes implemented in #1052 , so closing this PR. Thank you for the contribution!

@TCLamnidis TCLamnidis closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants