Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use singularity containers for PINTS #137

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Use singularity containers for PINTS #137

merged 1 commit into from
Mar 7, 2024

Conversation

edmundmiller
Copy link
Collaborator

@edmundmiller edmundmiller commented Feb 29, 2024 •
edited
Loading

Shouldn't be necessary anymore and singularity should just work ™️

Might fix an issue @YoshikiHigashijima had in Slack.

@edmundmiller edmundmiller changed the base branch from master to dev February 29, 2024 18:31
@edmundmiller edmundmiller self-assigned this Feb 29, 2024
@edmundmiller edmundmiller added this to the 2.2.0 milestone Feb 29, 2024
@nf-core nf-core deleted a comment from github-actions bot Feb 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 29, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 705099f

+| ✅ 168 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   5 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-03-07 19:00:56

@edmundmiller edmundmiller modified the milestones: 2.2.0, 2.3.0 Mar 1, 2024
@edmundmiller edmundmiller force-pushed the dev branch 2 times, most recently from 9bc50ae to 618e3a7 Compare March 5, 2024 16:19
@edmundmiller edmundmiller marked this pull request as ready for review March 5, 2024 18:43
@edmundmiller edmundmiller merged commit 14cba30 into dev Mar 7, 2024
4 checks passed
@edmundmiller edmundmiller deleted the pints-singularity branch March 7, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundmiller @maxulysse