Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GFFREAD bug #162

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Fix GFFREAD bug #162

merged 6 commits into from
Sep 11, 2024

Conversation

edmundmiller
Copy link
Collaborator

  • fix: Add fasta channel to GFFREAD
  • test: Add test for GFF files
  • test: Add a test for using a gzipped gff file

@edmundmiller edmundmiller self-assigned this Aug 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 30, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 531378a

+| ✅ 199 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in README.md: Describe the minimum required steps to execute the pipeline, e.g. how to prepare samplesheets.
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • actions_ci - actions_ci

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-11 16:24:20

SPPearce
SPPearce approved these changes Aug 31, 2024
View reviewed changes
Copy link

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@edmundmiller edmundmiller force-pushed the gffread_bug branch 4 times, most recently from e9179aa to 49f9b85 Compare September 11, 2024 15:49
@edmundmiller edmundmiller merged commit 5b222ff into dev Sep 11, 2024
6 checks passed
@edmundmiller edmundmiller deleted the gffread_bug branch September 11, 2024 17:19
@edmundmiller edmundmiller added this to the 2.3.0 milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce approved these changes

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundmiller @SPPearce