Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare RC 3.16.0 #1394

Merged
merged 7 commits into from
Oct 2, 2024
Merged

prepare RC 3.16.0 #1394

merged 7 commits into from
Oct 2, 2024

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Sep 30, 2024 •
edited
Loading

Prepare Release Candidate 3.16.0 aka Fire Ferret

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 30, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 73c8101

+| ✅ 173 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   8 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • nextflow_config - Config manifest.version should end in dev: 3.16.0
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-10-02 08:19:04

@maxulysse maxulysse mentioned this pull request Sep 30, 2024
Merged
11 tasks
@pinin4fjords
Copy link
Member

@maxulysse I think this needs to be 3.16.0, since we're doing more than fixing bugs.

@maxulysse
Copy link
Member Author

Ok, new release name?

@maxulysse maxulysse changed the title prepare RC 3.15.2 prepare RC 3.16.0 Oct 1, 2024
@pinin4fjords
Copy link
Member

Ok, new release name?

You've done the work this time, I'll give you the honour :-)

maxulysse
maxulysse commented Oct 1, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@maxulysse
Copy link
Member Author

Ok, new release name?

You've done the work this time, I'll give you the honour :-)

ok, I'm going with Fire Ferret then

pinin4fjords
pinin4fjords approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once any minor merge issues are resolved. I checked for inconsistencies between this and the last release and found none (though we need to start testing the new Kraken functionality in a future PR)

@maxulysse
Copy link
Member Author

LGTM once any minor merge issues are resolved. I checked for inconsistencies between this and the last release and found none (though we need to start testing the new Kraken functionality in a future PR)

All merge issues are solved. Only problem now one hisat2 file is slightly less stable than expected

@maxulysse maxulysse merged commit 2867938 into nf-core:dev Oct 2, 2024
24 checks passed
@maxulysse maxulysse deleted the prepare_3.15.2 branch October 2, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @pinin4fjords