Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v3.0.2 #1407

Merged
merged 6 commits into from
Oct 11, 2024
Merged

Important! Template update for nf-core/tools v3.0.2 #1407

merged 6 commits into from
Oct 11, 2024

Conversation

nf-core-bot
Copy link
Member

Version 3.0.2 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-3.0.2 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v3.0.2 release page.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f44e93a

+| ✅ 186 tests passed       |+
#| ❔   9 tests were ignored |#
!| ❗   8 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2024-10-11 14:00:48

@maxulysse
Copy link
Member

so nf-core template version comment will fail until the fixed actions is merged to dev

LouisLeNezet
LouisLeNezet approved these changes Oct 11, 2024
View reviewed changes
tests/default.nf.test.snap
@@ -83,8 +83,7 @@
],
[
"genome_transcriptome.fasta:md5,d41d8cd98f00b204e9800998ecf8427e",
"genome_transcriptome.gtf:md5,d41d8cd98f00b204e9800998ecf8427e",
"multiqc_plots:md5,d41d8cd98f00b204e9800998ecf8427e"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is multiqc plots md5 removed ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is a stub test, and it was actually a file before but now the module has been fixed upstream, and it's a proper folder, and so no longer getting captured by nf-test, hence the removal

@maxulysse maxulysse merged commit 4b46c7b into dev Oct 11, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@LouisLeNezet LouisLeNezet LouisLeNezet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nf-core-bot @maxulysse @LouisLeNezet