Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented MSISENSORPRO tumor-only analysis #1633

Closed
wants to merge 7 commits into from
Closed

Conversation

bounlu
Copy link

@bounlu bounlu commented Aug 27, 2024

Implements #1599 and #330

MSIsensorpro now also works with tumor-only samples if a baseline is provided by the user:

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@famosab
Copy link
Contributor

famosab commented Aug 29, 2024

I think you have to run nf-core lint locally and fix the installation of the msisensorpro module.

@bounlu
Copy link
Author

bounlu commented Sep 2, 2024

I can't install nf-core as it conflicts with my conda environment.

@famosab
Copy link
Contributor

famosab commented Sep 2, 2024

Ok I found the issue: The module has to be finished first here nf-core/modules#6350 and then be installed to sarek via nf-core modules msisensorpro/msitumoronly. Then the linting checks will be successful.

@bounlu bounlu closed this Sep 10, 2024
@bounlu bounlu deleted the master branch September 10, 2024 07:10
@bounlu bounlu restored the master branch September 10, 2024 07:11
@bounlu bounlu deleted the master branch September 10, 2024 07:16
@bounlu bounlu restored the master branch September 10, 2024 07:17
@bounlu bounlu reopened this Sep 10, 2024
@bounlu bounlu closed this Sep 10, 2024
@bounlu bounlu deleted the master branch September 10, 2024 07:30
@bounlu bounlu restored the master branch September 10, 2024 07:34
@bounlu bounlu deleted the master branch September 10, 2024 07:34
@bounlu bounlu restored the master branch September 10, 2024 07:35
@bounlu bounlu reopened this Sep 10, 2024
@bounlu bounlu closed this by deleting the head repository Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants