Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate samples into single object #56

Open
grst opened this issue Jun 27, 2023 · 4 comments
Open

Aggregate samples into single object #56

grst opened this issue Jun 27, 2023 · 4 comments
Assignees
Labels
enhancement Improvement for existing functionality

Comments

@grst
Copy link
Member

grst commented Jun 27, 2023

Description of feature

Would be nice to have a single object instead of inidividual h5ad files.
Optional batch correction for integration.

@grst grst added the enhancement Improvement for existing functionality label Jun 27, 2023
@grst
Copy link
Member Author

grst commented Aug 8, 2023

I would like to refactor a bit how AnnData objects are created and handled

  • instead of having a separate AnnData object after each step, I'd just go for two: one which has low quality spots removed and one that doesn't. Raw counts and normalized values can be stored in a single object using adata.layers.
  • rely on scanpy or squidpy to read visium data (@fasterius, what was again the motivation to have a custom python script for that in the first place?)
  • merge all objects into a single AnnData object at the end, with optional export to a SpatialData object (Add SpatialData as output #39).

I'd be happy to put a PR together.

@fasterius / @cavenel WDYT?

@fasterius
Copy link
Collaborator

Sounds good to me! I haven't really done any of the coding inside the reports, so don't have much to add - you'll have to ask @cavenel regarding your second point about the custom script. Might be due to legacy code from the Jackson Laboratory version of the pipeline, but that's just a guess.

@fasterius
Copy link
Collaborator

With the latest updates to the pipeline I think that we fulfill your first two points @grst. Regarding the third point, do you mean "merge" as in some kind of integration or just something else?

@grst
Copy link
Member Author

grst commented May 21, 2024

I just mean storing all samples in a single SpatialData object rather than having one SpatialData object per sample.

@fasterius fasterius assigned fasterius and cavenel and unassigned fasterius Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants