Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORECHOP_ABI patch (on bouncy_basenji dev branch) overwrites input #521

Closed
jfy133 opened this issue Sep 10, 2024 · 0 comments · Fixed by #522
Closed

PORECHOP_ABI patch (on bouncy_basenji dev branch) overwrites input #521

jfy133 opened this issue Sep 10, 2024 · 0 comments · Fixed by #522
Labels
bug Something isn't working

Comments

@jfy133
Copy link
Member

jfy133 commented Sep 10, 2024

Description of the bug

The patch is command is faulty:

+     ## To ensure ID matches rest of pipeline based on meta.id rather than input file name
+
+    [[ -f ${prefix}.fastq.gz   ]] || ln -s $reads ${prefix}.fastq.gz

This will symlink is fine, but then the symlinked input file can be then the same as the output file, so overwrites itself to the original file, rather than a new file...

Command used and terminal output

No response

Relevant files

No response

System information

No response

@jfy133 jfy133 added the bug Something isn't working label Sep 10, 2024
@jfy133 jfy133 linked a pull request Sep 10, 2024 that will close this issue
11 tasks
@jfy133 jfy133 closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant