Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nanopore patch #522

Merged
merged 4 commits into from
Sep 10, 2024
Merged

Remove nanopore patch #522

merged 4 commits into from
Sep 10, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Sep 10, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/taxprofiler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 linked an issue Sep 10, 2024 that may be closed by this pull request
@jfy133
Copy link
Member Author

jfy133 commented Sep 10, 2024

@nf-core-bot fix linting

Copy link

github-actions bot commented Sep 10, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit b22bb1d

+| ✅ 268 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in ci.yml: You can customise CI pipeline run tests as required

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-10 13:53:59

Copy link
Contributor

@LilyAnderssonLee LilyAnderssonLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for the merge once all tests have passed.

@jfy133 jfy133 merged commit 8949ad4 into bouncy-basenji Sep 10, 2024
24 checks passed
@jfy133 jfy133 deleted the remove-nanopore-patch branch September 10, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PORECHOP_ABI patch (on bouncy_basenji dev branch) overwrites input
2 participants