Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New shop page #2340

Merged
merged 14 commits into from
Oct 14, 2024
Merged

New shop page #2340

merged 14 commits into from
Oct 14, 2024

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 1, 2024 •
edited
Loading

Embeds spreadshop, with some CSS customisation

🤫

@netlify /shop

@ewels
New shop page
2659ecb 
Embeds spreadshop, with some CSS customisation
@ewels ewels requested a review from mashehu March 1, 2024 16:52
@netlify Netlify
Copy link

netlify bot commented Mar 1, 2024 •
edited
Loading

✅ Deploy Preview for nf-core-main-site ready!

Name Link
🔨 Latest commit 8a269c4
🔍 Latest deploy log https://app.netlify.com/sites/nf-core-main-site/deploys/670d610275033500083dfdeb
😎 Deploy Preview https://deploy-preview-2340--nf-core-main-site.netlify.app/shop
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ewels ewels marked this pull request as draft March 1, 2024 16:53
@edmundmiller
Copy link
Contributor

Will this auto-redirect to the US shop? 🤔

@ewels
Copy link
Member Author

ewels commented Mar 1, 2024

Not sure, you tell me! https://deploy-preview-2340--nf-core.netlify.app/shop/

For me it's showing GBP, so it might be a bit funky.

I was also thinking about having a FAQ and stuff - so might be worth having our own landing page before going through to the shop pages. Could then have links to the different shop sites, along with some FAQ. What do you think?

@edmundmiller
Copy link
Contributor

I'm getting pounds 😞

Yeah that could work. I bet we could render one or the other based on location.

@ewels
Copy link
Member Author

ewels commented Mar 2, 2024

Ok, I googled a bit more and also came to the same conclusion - that the auto redirect wouldn't work.

Just put together an index page and then location-specific embed pages under a dropdown. This should be more reliable. Also the FAQ mean that people hopefully know what they're getting themselves into.

Let me know what you think.

edmundmiller
edmundmiller approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks lovely now! Love the FAQ before a shop renders. I agree that should be more reliable.

@nvnieuwk
Copy link
Contributor

One small thing I've noticed is that by selecting the Belgium: Dutch Euro option, it actually displays the page in French (which can be an issue because not all Flemish people speak French fluently, asking for a friend 😁)

@mashehu mashehu self-assigned this Oct 11, 2024
@github-actions github-actions bot deleted a comment from netlify bot Oct 14, 2024
@ewels ewels marked this pull request as ready for review October 14, 2024 12:32
@ewels ewels mentioned this pull request Oct 14, 2024
Draft
FriederikeHanssen
FriederikeHanssen approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfy133 jfy133 self-requested a review October 14, 2024 15:41
jfy133
jfy133 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add a note on the embed page that makes sure to check all pages to see all designs e.g. pipeline specific ones, or mention they exist in the description

@ewels
Copy link
Member Author

ewels commented Oct 14, 2024

Thanks all - I'll add some "highlights" boxes above the button to go to the shop:

  • pipeline specific swag
  • customise your colours
  • big range of products

With subtext to explain how to eg. see the full list of products.

@ewels
Copy link
Member Author

ewels commented Oct 14, 2024

Done 🎨

@ewels ewels merged commit aecf54d into nf-core:main Oct 14, 2024
12 checks passed
@ewels ewels deleted the shop-attempt-2 branch October 14, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

@jfy133 jfy133 jfy133 approved these changes

@edmundmiller edmundmiller edmundmiller approved these changes

@mashehu mashehu Awaiting requested review from mashehu

Assignees

@ewels ewels

@mashehu mashehu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ewels @edmundmiller @nvnieuwk @maxulysse @FriederikeHanssen @jfy133 @mashehu